fix: Observed Packet Metric #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojamya
requested review from
jackzampolin,
jtieri and
mark-rushakoff
as code owners
jtieri
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR was to fix the
ShouldRelayChannelmethod in the case where there was no path filter rule in the relayer config.We discovered an issue when tracking
cosmos_relayer_observed_packetsmetric. When no filter was applied to a path, we were observing packets that were irrelevant to the path(s) the relayer was configured for.To fix this we now check if the channelKey is in the
channelStateCachein thepathEndRunTimeShouldRelayChannelfrompath_endtopath_end_runtimeThe unit tests were refactored.
Closes #1341