feat: multi zone - plugin & reflection #8

bizk · 2023-07-04T15:49:45Z

Description

Main feature: Enable Rosetta multi zone compatibility

Closes:

Changes on this PR

Added plugins feature in order to onboard custom types
Added reflection feature to infeer node types through reflection
Updated packages versioning
Fixed minor sdkTx variables issue
Roll back some changes on config.
Fixed makefile build
improvements over lint
Added makefile build plugin steps
Added docs
Improved test github ci a

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

[*] included the correct type prefix in the PR title
[*] added ! to the type prefix if API or client breaking change
[*] targeted the correct branch (see PR Targeting)
[/] provided a link to the relevant issue or specification
[*] followed the guidelines for building modules
[/] included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
[*] included comments for documenting Go code
[*] updated the relevant documentation or specification
[*] reviewed "Files changed" and left comments if necessary
[*] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

* added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names

bizk · 2023-07-06T12:38:48Z

CC: @julienrbrt who should we add as reviewers of this code?

julienrbrt · 2023-07-06T12:42:40Z

CC: @julienrbrt who should we add as reviewers of this code?

Hum, I don't know. Are you (Zondax) not the sole maintainer of this now 😬?
Probably @tac0turtle will have a better answer.

bizk · 2023-07-07T21:11:30Z

Thx for the response @julienrbrt ! We are the main mainteiners, thought it would be nice to check it with other devs who were involved on it, lets sync up with @tac0turtle

JulianToledano

LGTM!
my only concern is the plugin path is not configurable right now but we can address that in other pr

JulianToledano · 2023-07-13T10:02:22Z

Makefile

@@ -6,10 +6,13 @@ rosetta:
 	go build -mod=readonly ./cmd/rosetta

 build:
-	go build ./cmd/rosetta.go
+	go build -mod=readonly ./cmd/rosetta
+


whats the difference between this two? should we compile inside a build dir??

JulianToledano · 2023-07-13T10:03:29Z

README.md

+go install cosmossdk.io/rosetta/cmd/rosetta
+```
+
+Alternatively, for building from source, simply run `make rosetta`. The binary will be located in `tools/rosetta`.


I think this is not correct right now as make rosetta compiles the binary in the root project dir

I do not think this has been yet updated.

README.md

plugins.go

julienrbrt

utACK.

Unrelated question: are you going to submit a PR to remove it from the SDK main?

README.md

julienrbrt · 2023-07-14T16:56:52Z

README.md

+go install cosmossdk.io/rosetta/cmd/rosetta
+```
+
+Alternatively, for building from source, simply run `make rosetta`. The binary will be located in `tools/rosetta`.


I do not think this has been yet updated.

julienrbrt · 2023-07-14T16:59:01Z

go.mod

-	github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230614103911-b3da8bb4e801
-	github.com/cosmos/gogoproto v1.4.10
+	github.com/cometbft/cometbft v0.37.2
+	github.com/cosmos/cosmos-sdk v0.47.3


Given that we already have a Rosetta version released for v0.47, doesn't it makes more sense to integrate with 0.50 already?

yaah it makes sense, i would wait until v0.50 is out of alpha tbh.
Once merged this I will move on to clean up rosetta from cosmos-sdk
thx for the review :)

* added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Updated documentation and added --plugin flag * updated install step on README * lint fix * updated docs

bizk · 2023-07-18T23:16:19Z

Any clue why we cannot merge this?
CC: @julienrbrt @JulianToledano @tac0turtle

julienrbrt · 2023-07-19T06:15:23Z

Any clue why we cannot merge this? CC: @julienrbrt @JulianToledano @tac0turtle

For some reason, the approval didn't work. Re-approved and now it seems you can merge.

* feat: multi zone - plugin & reflection (#5) * added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Zondax/feature/multi zone fix * added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Updated documentation and added --plugin flag * updated install step on README * lint fix * updated docs * updated go.sum (#8) * refactor: Upgrade rosetta to cosmos-sdk v0.50.0 (#7) * changed go.mod name, renamed dependencies on rosetta, adapted methods and uses of cosmos-sdk, upgraded dependencies * fixed all code errors * improvements over parsing * fees and gas parsing * remmoved validation on message due to deprecation (it should be validated on the server side) * solved issue on missing tx tipper * added codec types * fixed interface registre addr issue * improvements * fixed converter tests * commented plugin_test.go due to some modules not being available at v0.50 yet * improved code, moved parsing functions to utils.go * solved comments, fixed lint and added utils.go for parsing * fixed comment on cast variables * lint comments * Commented ibc-go dependdency until upgrade * added type assertion error handlinhg * updated go.sum * rename module for vanity url * update go.mod and go.sum

* feat: multi zone - plugin & reflection (#5) * added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Zondax/feature/multi zone fix * added plugins feature and reflection features * fixed minor sdkTx variables issue * Roll back some changes on config.go * fixed makefile build command * improvements over lint * Added nolint ant changed variable name * fix .gitworkflow build * fix .gitworkflow build * Added makefile build plugin steps * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * added nolint on staticcheck on load.go * gofumpt on project * skiped a test due to reliance on an experimental feature of cosmos v0.46.0-beta * build plugin before test * build plugin before test * fixed failing test * fix make test * added docs * small refactor on variable names * Updated documentation and added --plugin flag * updated install step on README * lint fix * updated docs * updated go.sum (#8) * refactor: Upgrade rosetta to cosmos-sdk v0.50.0 (#7) * changed go.mod name, renamed dependencies on rosetta, adapted methods and uses of cosmos-sdk, upgraded dependencies * fixed all code errors * improvements over parsing * fees and gas parsing * remmoved validation on message due to deprecation (it should be validated on the server side) * solved issue on missing tx tipper * added codec types * fixed interface registre addr issue * improvements * fixed converter tests * commented plugin_test.go due to some modules not being available at v0.50 yet * improved code, moved parsing functions to utils.go * solved comments, fixed lint and added utils.go for parsing * fixed comment on cast variables * lint comments * Commented ibc-go dependdency until upgrade * added type assertion error handlinhg * updated go.sum * rename module for vanity url * update go.mod and go.sum * refactor: error handling improvements (#9) * issue on load.go * fixed tests * added client offline * client_online.go * added error handling on utils.go and unified both files * added plugins.go * added config, converter and libraries * linted and fixed issues * fixed some issues

bizk self-assigned this Jul 4, 2023

bizk marked this pull request as ready for review July 4, 2023 16:03

JulianToledano approved these changes Jul 13, 2023

View reviewed changes

ainhoa-a mentioned this pull request Jul 14, 2023

EPIC: Zondax maintenance Q2/23 cosmos/cosmos-sdk#16220

Closed

25 tasks

julienrbrt approved these changes Jul 14, 2023

View reviewed changes

julienrbrt approved these changes Jul 19, 2023

View reviewed changes

tac0turtle merged commit 61f1cbb into cosmos:main Jul 19, 2023
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: multi zone - plugin & reflection #8

feat: multi zone - plugin & reflection #8

bizk commented Jul 4, 2023 •

edited

Loading

bizk commented Jul 6, 2023

julienrbrt commented Jul 6, 2023

bizk commented Jul 7, 2023

JulianToledano left a comment

JulianToledano Jul 13, 2023

JulianToledano Jul 13, 2023

bizk Jul 14, 2023

julienrbrt Jul 14, 2023

julienrbrt left a comment

julienrbrt Jul 14, 2023

julienrbrt Jul 14, 2023

bizk Jul 14, 2023

bizk commented Jul 18, 2023 •

edited

Loading

julienrbrt commented Jul 19, 2023

feat: multi zone - plugin & reflection #8

feat: multi zone - plugin & reflection #8

Conversation

bizk commented Jul 4, 2023 • edited Loading

Description

Author Checklist

Reviewers Checklist

bizk commented Jul 6, 2023

julienrbrt commented Jul 6, 2023

bizk commented Jul 7, 2023

JulianToledano left a comment

Choose a reason for hiding this comment

JulianToledano Jul 13, 2023

Choose a reason for hiding this comment

JulianToledano Jul 13, 2023

Choose a reason for hiding this comment

bizk Jul 14, 2023

Choose a reason for hiding this comment

julienrbrt Jul 14, 2023

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt Jul 14, 2023

Choose a reason for hiding this comment

julienrbrt Jul 14, 2023

Choose a reason for hiding this comment

bizk Jul 14, 2023

Choose a reason for hiding this comment

bizk commented Jul 18, 2023 • edited Loading

julienrbrt commented Jul 19, 2023

bizk commented Jul 4, 2023 •

edited

Loading

bizk commented Jul 18, 2023 •

edited

Loading