Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message tests #136

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@marbar3778
Copy link
Contributor

commented Sep 7, 2019

  • step 1 of adding testing to the tutorial

ref #13

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Add message tests
- step 1 of adding testing to the tutorial

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

@marbar3778 marbar3778 requested a review from hschoenburg Sep 7, 2019

@marbar3778 marbar3778 self-assigned this Sep 7, 2019

func TestMsgSetName(t *testing.T) {
name := "maTurtle"
value := "1"
acc := sdk.AccAddress([]byte("me"))

This comment has been minimized.

Copy link
@okwme

okwme Sep 9, 2019

Collaborator

not clear to me what's going on here. If you instantiate an address using an arbitrary byte string is that used as the private key?

This comment has been minimized.

Copy link
@marbar3778

marbar3778 Sep 9, 2019

Author Contributor

this is just creating a dummy account for testing. there is no need fo the priv key here, once we do simulaiton tests we will need to integrate something with priv key i believe

This comment has been minimized.

Copy link
@hschoenburg

hschoenburg Sep 9, 2019

Contributor

i think its ok not to use valid addresses here since the test is focused on the nameservice message

@okwme
okwme approved these changes Sep 9, 2019
Copy link
Collaborator

left a comment

would like to see more tests cover edge cases and actual errors but this is a great start 👍

@hschoenburg
Copy link
Contributor

left a comment

nice and straightforward!

@marbar3778 marbar3778 force-pushed the marko/addmsgtests branch from a825886 to ccd8b97 Sep 13, 2019

@marbar3778 marbar3778 merged commit d637005 into master Sep 13, 2019

@marbar3778 marbar3778 deleted the marko/addmsgtests branch Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.