Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Atmospheres #368

Merged
merged 170 commits into from
Jan 30, 2024
Merged

New Atmospheres #368

merged 170 commits into from
Jan 30, 2024

Conversation

Schneegans
Copy link
Member

This pull request generalizes the implementation of the Bruneton model by loading phase functions, extinction coefficients, and particle density distributions from CSV files. This allows us to simulate arbitrary particle types. In particular, we can now use Mie Theory to pre-compute the scattering behaviour of a wide variety of particle types, including for instance Martian dust.

In addition, the source code of the model has received some refactoring making it more inline with the rest of CosmoScout's source code.

Also, a lot of documentation has been added.

@Schneegans Schneegans marked this pull request as ready for review January 23, 2024 08:30
@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7707851252

  • -689 of 689 (0.0%) changed or added relevant lines in 7 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 1.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-atmospheres/src/Atmosphere.hpp 0 1 0.0%
plugins/csp-atmospheres/src/models/bruneton/Model.hpp 0 1 0.0%
plugins/csp-atmospheres/src/Plugin.cpp 0 7 0.0%
plugins/csp-atmospheres/src/Atmosphere.cpp 0 69 0.0%
plugins/csp-atmospheres/src/models/bruneton/internal/csv.cpp 0 80 0.0%
plugins/csp-atmospheres/src/models/bruneton/Model.cpp 0 102 0.0%
plugins/csp-atmospheres/src/models/bruneton/internal/Implementation.cpp 0 429 0.0%
Files with Coverage Reduction New Missed Lines %
plugins/csp-atmospheres/src/models/bruneton/Model.hpp 1 0.0%
plugins/csp-atmospheres/src/models/bruneton/Model.cpp 2 0.0%
plugins/csp-atmospheres/src/Plugin.cpp 2 0.0%
plugins/csp-atmospheres/src/Atmosphere.cpp 3 0.0%
Totals Coverage Status
Change from base Build 7274803696: -0.02%
Covered Lines: 193
Relevant Lines: 16825

💛 - Coveralls

Copy link
Member

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some small remarks, but once they are adressed this can be merged.

plugins/csp-atmospheres/README.md Outdated Show resolved Hide resolved
plugins/csp-atmospheres/preprocessor/angstromMode.cpp Outdated Show resolved Hide resolved
plugins/csp-atmospheres/preprocessor/README.md Outdated Show resolved Hide resolved
plugins/csp-atmospheres/preprocessor/common.hpp Outdated Show resolved Hide resolved
plugins/csp-atmospheres/preprocessor/main.cpp Outdated Show resolved Hide resolved
@Schneegans Schneegans merged commit dfa0b78 into main Jan 30, 2024
11 of 12 checks passed
@Schneegans Schneegans deleted the feature/new-atmospheres branch January 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants