Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Go to 1.22 #529

Merged
merged 2 commits into from
Feb 21, 2024
Merged

chore: bump Go to 1.22 #529

merged 2 commits into from
Feb 21, 2024

Conversation

troutowicz
Copy link
Contributor

No description provided.

@adrianosela
Copy link

Hey @cosmtrek - a new release supporting the latest version of go would be reaallyyy nice. Air is preventing my team from bumping our projects to 1.22 (since it breaks our engineers' local dev worklows).

@cosmtrek
Copy link
Collaborator

@troutowicz Hi, could you fix the tests? Thanks

@troutowicz
Copy link
Contributor Author

Hey @cosmtrek, removed that second commit. Will address GH action config another time.

go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/cosmtrek/air

go 1.21
go 1.22.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to keep this on the major version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially tried this but received the following error on go mod tidy

go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Was a local installation issue.

@troutowicz
Copy link
Contributor Author

troutowicz commented Feb 18, 2024

Hey @cosmtrek - a new release supporting the latest version of go would be reaallyyy nice. Air is preventing my team from bumping our projects to 1.22 (since it breaks our engineers' local dev worklows).

We were having the same issue. However, for future blocks, I think setting a newer toolchain will address local dev workflows.

go 1.21

toolchain go1.22.0

https://go.dev/blog/toolchain

@adrianosela
Copy link

Hey @cosmtrek -- sorry to bother again. Can we merge this?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c81890) 69.22% compared to head (483f6ce) 65.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   69.22%   65.28%   -3.94%     
==========================================
  Files           9       10       +1     
  Lines        1082     1158      +76     
==========================================
+ Hits          749      756       +7     
- Misses        253      324      +71     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmtrek cosmtrek merged commit 076ad27 into air-verse:master Feb 21, 2024
9 of 10 checks passed
@troutowicz troutowicz deleted the go-1.22 branch February 21, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants