Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2015-01-11-the-material-of-data-science-for-the-vacation.md #23

Merged
merged 2 commits into from
Mar 19, 2017
Merged

Update 2015-01-11-the-material-of-data-science-for-the-vacation.md #23

merged 2 commits into from
Mar 19, 2017

Conversation

RockYanShi
Copy link
Contributor

No description provided.

tomatoiscoding
tomatoiscoding requested changes Mar 18, 2017
View reviewed changes
Copy link
Member

@tomatoiscoding tomatoiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er...据我点了点，后两个链接是挂的。。要不要标注一下？

@RockYanShi
Update 2015-01-11-the-material-of-data-science-for-the-vacation.md
4306f94 
可视化段乱中的  质疑 的链接也失效了 已标注
@tomatoiscoding
Copy link
Member

我好像又无法merge了... @yihui

@yihui
Copy link
Member

yihui commented Mar 18, 2017

@tomatoiscoding 现在应该好了。

@tomatoiscoding tomatoiscoding merged commit c248936 into cosname:master Mar 19, 2017
@yihui
Copy link
Member

yihui commented Mar 19, 2017

@tomatoiscoding 忘了说了，当你自己修订文章时，记得用 git 命令行在自己 fork 的库里操作，不要直接在这个主库里用 Github 界面上的编辑按钮修订文章，因为你有管理员权限，如果通过界面操作，修订的文章会直接提交到 master 分支。

@tomatoiscoding
Copy link
Member

嗯嗯，知道啦！ @yihui

@hetong007
Copy link
Member

@tomatoiscoding 在你们Merge之后，顺便去 #4 里打钩标记吧。既然已经通过review之后merge了，谁来打钩都一样。在PR比较多的时候，我可能会漏掉几个。

@tomatoiscoding
Copy link
Member

好嘞 @hetong007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomatoiscoding tomatoiscoding tomatoiscoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RockYanShi @tomatoiscoding @yihui @hetong007