Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests with nohup #311

Merged
merged 3 commits into from Feb 5, 2019
Merged

run tests with nohup #311

merged 3 commits into from Feb 5, 2019

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Feb 4, 2019

after discovering last test faults I found that they freeze after unexpected sighup that didn't send in any our tests or inside acra-server. so I think it's some behaviour of circleci. when acra-server receive sighup signal then it fork new process to restart with new configuration and stop parent. our tests save pid of forked explicitly process but doesn't expect that parent process will fork new. so can't correctly stop child process. after that after this we have 2 conflicting acra-server
because in tests we send sighup with http api we doesn't need to receive it in acra-server and can ignore it to avoid blinking tests

Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow O_o
This is something rather deep I didn't expect to see

@vixentael vixentael added the tests label Feb 4, 2019
@Lagovas Lagovas merged commit 06ced91 into cossacklabs:master Feb 5, 2019
@Lagovas Lagovas deleted the lagovas/nohup-tests branch February 20, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants