Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidelines #360

Merged
merged 1 commit into from Mar 20, 2020
Merged

Conversation

ilammy
Copy link
Contributor

@ilammy ilammy commented Mar 19, 2020

Since the number of actual and possible developers is expanding, it’s probably time to describe the contribution guidelines more explicitly. Here's an initial version based on our existing documentation, primed with some friction points encountered during code review so far.

Please feel free to expand it as you see fit in the future.

Since the number of actual and possible developers is exanding, it's
probably time to describe the contribution guidelines more explicitly.
Here's an initial version based on our existing documentation, primed
with some friction points encountered during code review so far.
Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! Makes a lot of sense

var ErrCannotConnect = errors.New("AcraService: Cannot connect")
```

- Log messages should start with an uppercase letter.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@ilammy ilammy merged commit 1480901 into cossacklabs:master Mar 20, 2020
@ilammy ilammy deleted the contributing branch March 20, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants