Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search with aliased table #602

Merged
merged 3 commits into from Nov 23, 2022
Merged

Conversation

Zhaars
Copy link
Contributor

@Zhaars Zhaars commented Nov 21, 2022

Bug fixing related to mapping aliased table with config during searchable encryption table filtering.

In the queries like select ... from some_table as alias where searchable_col = value if the some_table is in encryptor config and searchable_col is not aliased column, Acra panic as default table remains nil and uninitialized. So that the main filtering logic was rewritten and is now based on findColumnInfo method that find table name depending on aliased or non-aliased tables in FROM statement and data from encryptor config.

Checklist

Fixed search issue with aliased table
@Zhaars Zhaars requested a review from Lagovas November 21, 2022 20:13
Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it faster or slower than existing solution?

@Zhaars
Copy link
Contributor Author

Zhaars commented Nov 21, 2022

is it faster or slower than existing solution?

Conceptually, it is the same solution, moreover deleted redundant stuff.

encryptor/utils.go Outdated Show resolved Hide resolved
encryptor/utils.go Outdated Show resolved Hide resolved
@Zhaars Zhaars merged commit a9a619c into master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants