Actualize acra-keys destroy info #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actualize info about acra-keys destroy subcommand
vixentael
reviewed
Jan 25, 2023
| @@ -8,7 +8,7 @@ weight: 7 | |||
| **`destroy`** is `acra-keys` subcommand used for destroying keypair from the keystore. | |||
|
|
|||
| {{< hint warning >}} | |||
| Since 0.91.0 `acra-keys` **`destroy`** doesn't support destroying keys and will be extended in subsequent versions. | |||
| From 0.91.0 to 0.94.0 `acra-keys` **`destroy`** doesn't support destroying keys and will be extended in subsequent versions. | |||
There was a problem hiding this comment.
- "destroy" command doesn't support destroying keys?
- "From 0.91.0 to 0.94.0" — do we expect this behavior to change in 0.95.0?
There was a problem hiding this comment.
-
Previously
destroycommand was only used for transport keys between connect/server/translator. Since we removed support of the connector in 0.91.0 - destroy command could not destroy keys. -
Yes, already prepared corresponded PR Extend acra-keys destroy acra#625
There was a problem hiding this comment.
destroy command could not destroy keys.
Why we need destroy command if it doesn't destroy the keys? 🤔
Maybe we need to clarify the wording?
There was a problem hiding this comment.
What do you think about that one @vixentael ?
Before 0.91.0 `acra-keys` **`destroy`** was used to destroy only transport keys. Since 0.91.0 transport keys support is deprecated, `acra-keys` **`destroy`** is unused.
Starting from 0.95.0 `acra-keys` **`destroy`** is extended to support all keys.
There was a problem hiding this comment.
Fantastic! One small change
Before 0.91.0 `acra-keys` **`destroy`** was used to destroy only transport keys. Since 0.91.0 transport keys support is deprecated, `acra-keys` **`destroy`** is unused.
Starting from 0.95.0 `acra-keys` **`destroy`** is extended to delete any types of keys.
Lagovas
reviewed
Jan 25, 2023
content/acra/configuring-maintaining/general-configuration/acra-keys/destroy.md
Show resolved
Hide resolved
content/acra/configuring-maintaining/general-configuration/acra-keys/destroy.md
Outdated
Show resolved
Hide resolved
content/acra/configuring-maintaining/general-configuration/acra-keys/destroy.md
Show resolved
Hide resolved
Fixed after review
Lagovas
reviewed
Jan 25, 2023
|
lgtm after resolving my last comment :D |
Fixed after review
vixentael
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actualize info about acra-keys destroy subcommand