New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix installing dependencies #239

Merged
merged 3 commits into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@Lagovas
Contributor

Lagovas commented Oct 4, 2017

drop redundant "define" option
up to 0.9.6-1 because published 0.9.6-0 without adding npm install && command (just with fixed library search paths) in preinstall script that fixes installing nan before building jsthemis

fix installing dependencies
drop redundant "define" option

@Lagovas Lagovas requested a review from vixentael Oct 4, 2017

@vixentael

This comment has been minimized.

Member

vixentael commented Oct 4, 2017

LGTM

@Lagovas Lagovas merged commit ae68ae0 into master Oct 4, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Lagovas Lagovas deleted the lagovas/update-npmjs-package branch Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment