Rename error.h files

[vixentael]

Currently core has two error.h files: inside soter and inside themis folders. It might cause compiler warnings due to same names.

Moreover, objc wrapper has error.h file inside too, this cause warning while building iOS (ObjC/Swift) examples.

Previously mentioned:

• Make exceptions and errors consistent on all platforms #63
• Can't build via CocoaPods on macOS High Sierra #219 (comment)

Changes:

• rename soter/error.h to soter/soter_error.h
• remove extra includes inside soter and themis
• rename objcthemis/serror.h to `objcthemis/serror.h

[Lagovas]

rename soter/error.h to soter/soter_error.h

I wanted to say that maybe we should rename themis/error.h to themis/themis_error.h and I remembered that this header file used in all wrappers... Did you check that soter/error.h not used anywhere in other parts of code?

rename objcthemis/serror.h to `objcthemis/serror.h

what do you think about objcthemis/soter_error.h for consistency? or if it will do the same error then objcthemis/objc_soter_error.h?

[vixentael]

1

we should rename themis/error.h to themis/themis_error.h

agree, i had the same thought. renamed.

2

what do you think about objcthemis/soter_error.h for consistency?

well, i don't really like the name objcthemis/serror.h, but it's aligned with objcthemis style:

3

Did you check that soter/error.h not used anywhere in other parts of code?

I hope we have tests for that :D

[Lagovas]

gothemis (in *.go files) uses themis/error.h and should be renamed too

[vixentael]

already did :)

thankfully, we have good tests!