Formatting: JsThemis native extension #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add native extension of JsThemis to "make fmt" target group. This requires quite a bit of effort because clang-tidy insists on having access to *all* source code involved in complation, including all those NodeJS headers and its modules. First of all, we have to add some hardcoded paths to NodeJS headers. I have not found a proper way to get these paths so we just hardcode them and hope that this is fine. Then we need to have <nan.h> header file for which we have to install the nan module. We do a little hack to achieve that, pretending to 'format' the installation path for Node modules.
This will make automated formatting a bit more nice.
forelocked-beobachter
requested review from
vixentael,
ignatk,
Lagovas and
shadinua
Install npm and nodejs as we need them for checking JsThemis native source code. At least for now.
Print out a warning when formatting files if NodeJS is not installed and we are not able to reformat JsThemis files.
The current build system for libthemis-src is quite messed up and requires peculiar symlinking to work. Add a symlink for the new file included from the main Makefile.
|
What's the reasoning behind re-ordering headers like in this commit? |
Consistency with other code that (now) uses include order suggested by Google Coding style:
Reordering itself does not change anything semantically, but I have optimized the headers a bit (such as removed |
ilammy
added
W-JsThemis 🍭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add native extension of JsThemis to
make fmttarget group.This requires quite a bit of effort because clang-tidy insists on having access to all source code involved in compilation, including all those NodeJS headers and its modules.
First of all, we have to add some hardcoded paths to NodeJS headers. I have not found a proper way to get these paths so we just hardcode them and hope that this is fine.
Then we need to have
<nan.h>header file for which we have to install the nan module. We do a little hack to achieve that, pretending to 'format' the installation path for Node modules.I have to say I'm not a fan of these hacks that we have to perform in order to get clang-tidy work on our source code...