Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Carthage examples to use Themis 0.13.2 #706

Merged
merged 3 commits into from Aug 14, 2020
Merged

Update Carthage examples to use Themis 0.13.2 #706

merged 3 commits into from Aug 14, 2020

Conversation

vixentael
Copy link
Contributor

@vixentael vixentael commented Aug 14, 2020 •
edited

After #705 0.13.2 release, let's keep iOS/macOS Carthage examples fresh!

Blocked by #707.

Checklist

  • Changelog is updated (in case of notable or breaking changes)

@vixentael vixentael requested a review from ilammy August 14, 2020 20:30
@vixentael vixentael added M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS labels Aug 14, 2020
@vixentael vixentael changed the title updating carthage examples to use themis 0.13.2 Update Carthage examples to use Themis 0.13.2 Aug 14, 2020
ilammy
ilammy approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by #707.

Not really.

@vixentael
Copy link
Contributor Author

vixentael commented Aug 14, 2020 •
edited

Not really.

Blocked, because I can't update ChangeLog yet :(

@ilammy
Copy link
Collaborator

ilammy commented Aug 14, 2020

Blocked, because I can't update ChangeLog yet :(

Yes you can. Just have to deal with conflicts later ;)

@vixentael
Copy link
Contributor Author

Just have to deal with conflicts later ;)

@ilammy
Copy link
Collaborator

ilammy commented Aug 14, 2020

@vixentael,

just do it

The keyword here is

later

@vixentael vixentael merged commit 83d65d4 into master Aug 14, 2020
@vixentael vixentael deleted the vxxtl/themis-0.13.2-examples branch August 14, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

@Lagovas Lagovas Awaiting requested review from Lagovas Lagovas is a code owner

Assignees
No one assigned
Labels
M-Carthage Package manager: Carthage, Objective-C and Swift, iOS and macOS O-iOS 📱 Operating system: iOS O-macOS 💻 Operating system: macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vixentael @ilammy