Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests directory for soter_test target #756

Merged
merged 1 commit into from Nov 27, 2020

Conversation

concatime
Copy link
Contributor

@concatime concatime commented Nov 27, 2020

Update CMakeLists to add tests directory with private headers for soter_test target.

Checklist

@Lagovas
Copy link
Collaborator

Lagovas commented Nov 27, 2020

wow, awesome) someone use cmake/CMakeLists.txt which we added more for internal usage and CLion integration (because main build system is make for us)
I tested locally and yes, without this patch soter tests fail with errors:

/themis/tests/soter/soter_asym_ka_test.c:17:10: fatal error: soter/soter_test.h: No such file or directory
   17 | #include "soter/soter_test.h"
      |          ^~~~~~~~~~~~~~~~~~~~

because we have hidden private headers. With the patch, it builds and runs successfully.

@vixentael vixentael added infrastructure Automated building and packaging tests Themis test suite labels Nov 27, 2020
@Lagovas Lagovas merged commit 0ea8030 into cossacklabs:master Nov 27, 2020
@concatime concatime deleted the patch-1 branch November 27, 2020 17:23
@ilammy
Copy link
Collaborator

ilammy commented Nov 27, 2020

Hey @concatime! Thanks for fixing up CMake! Indeeed, it's not used much for development or packaging. If I remember correctly, it was added some long time ago for better IDE support but it was not really maintained since then as no one really needed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Automated building and packaging tests Themis test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants