New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wasm-themis to be more compatible with TypeScript #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilammy
changed the title
Improve was-themis to be more compatible with TypeScript
Improve wasm-themis to be more compatible with TypeScript
Apr 12, 2022
ilammy
approved these changes
Apr 12, 2022
vixentael
reviewed
Apr 12, 2022
vixentael
added
the
W-WasmThemis 🌐
Wrapper: WasmThemis, JavaScript API, npm packages
label
Apr 12, 2022
ilammy
approved these changes
Apr 12, 2022
radetsky
force-pushed
the
wasm-improve-20220412
branch
from
April 12, 2022 14:43
60db84d
to
bc3b3a4
Compare
ilammy
requested changes
Apr 13, 2022
ilammy
approved these changes
Apr 14, 2022
vixentael
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In secure_cell_seal mode two encrypt method and one decrypt was declared with a single parameter and the developer used optional arguments to handle the optional context. When we use TypeScript to work with the Themis, the compiler generates the error while compiling in case of using a non-empty context.
I made a declaration of an optional parameter, not an argument (see javascript parameters vs arguments of function). Also, I remove a single case of test cases (see test.js diff) because undefined optional context is always ok. We can use it.
Checklist