Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wasm-themis to be more compatible with TypeScript #909

Merged
merged 8 commits into from Apr 14, 2022

Conversation

radetsky
Copy link
Contributor

@radetsky radetsky commented Apr 12, 2022

In secure_cell_seal mode two encrypt method and one decrypt was declared with a single parameter and the developer used optional arguments to handle the optional context. When we use TypeScript to work with the Themis, the compiler generates the error while compiling in case of using a non-empty context.

I made a declaration of an optional parameter, not an argument (see javascript parameters vs arguments of function). Also, I remove a single case of test cases (see test.js diff) because undefined optional context is always ok. We can use it.

Checklist

  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has proper documentation
  • Example projects and code samples are up-to-date (in case of API changes)
  • Changelog is updated (in case of notable or breaking changes)

@ilammy ilammy changed the title Improve was-themis to be more compatible with TypeScript Improve wasm-themis to be more compatible with TypeScript Apr 12, 2022
src/wrappers/themis/wasm/src/secure_cell_seal.ts Outdated Show resolved Hide resolved
src/wrappers/themis/wasm/package.json Outdated Show resolved Hide resolved
@vixentael vixentael added the W-WasmThemis 🌐 Wrapper: WasmThemis, JavaScript API, npm packages label Apr 12, 2022
@vixentael vixentael changed the base branch from master to release/0.14 April 12, 2022 14:25
src/wrappers/themis/wasm/package.json Outdated Show resolved Hide resolved
@radetsky radetsky merged commit 67732ab into release/0.14 Apr 14, 2022
@radetsky radetsky deleted the wasm-improve-20220412 branch April 14, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
W-WasmThemis 🌐 Wrapper: WasmThemis, JavaScript API, npm packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants