Hot fix: upgrade Android SDK version for React Native Themis #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
approved these changes
Jan 19, 2023
vixentael
changed the title
|
I think we should cherry pick this PR into |
ilammy
approved these changes
Jan 20, 2023
That would be neat to get green builds, but it doesn't seem that any of those CI jobs are checking React Native, so I don't think this PR should be blocked by red CI. For example, "Android emulator" job is unlikely to get fixed by rolling back the base system, and it's more of Android build system rot mitigated with upgrades on |
after seeing your comment in #980 I agree with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the issue #978