Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in export Hebrew text - add UTF-8 BOM to CSV export #38

Closed
Royb10 opened this issue Oct 26, 2022 · 4 comments
Closed

Issue in export Hebrew text - add UTF-8 BOM to CSV export #38

Royb10 opened this issue Oct 26, 2022 · 4 comments

Comments

@Royb10
Copy link

Royb10 commented Oct 26, 2022

Thanks for the great tool!
I found an issue - The CSV file should be saved as UTF-8 otherwise Excel and other encoding-sensitive applications may show gibberish instead of Hebrew characters.

You can see the Title column:
utf-8 export issue

If I open the file with Notepad or import it to excel using Excel Data tools - all good.
I think the solution is to add UTF-8 BOM to CSV export, maybe this could help:
https://stackoverflow.com/questions/17879198/adding-utf-8-bom-to-string-blob/27975629#27975629

@coston
Copy link
Owner

coston commented Oct 26, 2022

Hey @Royb10, thank you for sharing this issue. The default encoding for blob is UTF-8, so we'd only need to add the BOM marker. Seems fine to me. Is there downside to doing this? (i'm wondering why it's not the default)

@Royb10
Copy link
Author

Royb10 commented Oct 26, 2022

Hi @coston, thanks for the quick reply!
From what I've checked and researched, I don't see any downside. really interesting why it's not the default...

coston added a commit that referenced this issue Oct 28, 2022
* feat: BOM support for special characters in Excel

* chore: upgrade lockfile
@coston
Copy link
Owner

coston commented Oct 28, 2022

Hey @Royb10, BOM support is available in v2.1.0

@coston coston closed this as completed Oct 28, 2022
@Royb10
Copy link
Author

Royb10 commented Oct 29, 2022

Works perfectly, thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants