-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in export Hebrew text - add UTF-8 BOM to CSV export #38
Comments
Hey @Royb10, thank you for sharing this issue. The default encoding for blob is UTF-8, so we'd only need to add the BOM marker. Seems fine to me. Is there downside to doing this? (i'm wondering why it's not the default) |
Hi @coston, thanks for the quick reply! |
coston
added a commit
that referenced
this issue
Oct 28, 2022
Works perfectly, thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the great tool!
I found an issue - The CSV file should be saved as UTF-8 otherwise Excel and other encoding-sensitive applications may show gibberish instead of Hebrew characters.
You can see the Title column:
If I open the file with Notepad or import it to excel using Excel Data tools - all good.
I think the solution is to add UTF-8 BOM to CSV export, maybe this could help:
https://stackoverflow.com/questions/17879198/adding-utf-8-bom-to-string-blob/27975629#27975629
The text was updated successfully, but these errors were encountered: