This repository has been archived by the owner on Jun 30, 2019. It is now read-only.
Refactor protocol #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enum is bad for integration with other programs. See: https://docs.python.org/3/library/enum.html#comparisons 在调试的时候，我们想改变 Player 的状态，直接的想法是： player.state = 3 而之前使用 Enum 的话，就不能这么直接的完成，需要 player.state = State.xxx 在真正的代码中，更推荐使用后者，但是在调试时，前者方便许多，所以将 Enum 改成 IntEnum
* fixtures re-org * add xiami provider * 整理代码：补充测试和文档 * 支持虾米音乐用户登录等功能 * 通过手动测试
…nto refactor-protocol
|
merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.