Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility Bug] Contrast issue in tagline #447

Closed
3 tasks done
bhavykhatri opened this issue Nov 21, 2021 · 1 comment
Closed
3 tasks done

[Accessibility Bug] Contrast issue in tagline #447

bhavykhatri opened this issue Nov 21, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@bhavykhatri
Copy link
Contributor

bhavykhatri commented Nov 21, 2021

Checklist

  • I have read the tutorials and know the correct effect of the functional design.
  • There are no similar reports on existing issues (including closed ones).
  • I found the bug on the latest code of the master branch.

Describe the bug

Contrast in both dark and light mode for tagline is not according to the guideline.

image
image

I also felt that the tagline has contrast issue and the text is not really that visible as it should be

To Reproduce

Steps to reproduce the behavior:

  1. Use Accessiblity insight for windows (or any other contrast tool)
  2. Go to contrast section.
  3. Pick up the color for background and text
  4. Notice the ratio is not as per the guideline.

Expected behavior

Text should be properly visible as per accessibility guideline.

Screenshots

Provided above

Software

  • Ruby version: 2.7.4p191
  • Gem version: 3.1.6
  • Bundler version: 2.2.30

Desktop

Smartphone

Additional context

Possible resolution would be to just increase the contrast ratio a bit like this which would resolve the issue.
image

@cotes2020
Copy link
Owner

Thank you for submitting this issue, it is very detailed and there is a related PR!

The low color contrast ratio is to prevent the sub-title (tagline) from getting the first attention. There are some other texts on this theme also use this strategy, for example, the metadata of the posts, the copyright information of the footer, etc.

@cotes2020 cotes2020 added the wontfix This will not be worked on label Nov 22, 2021
cotes2020 added a commit that referenced this issue Aug 1, 2023
- Make color and contrast meets WCAG 2 AA and above
- Fixes `aria-label` on button "copy link" in posts

Closes #1095, closes #1104
cotes2020 added a commit that referenced this issue Aug 2, 2023
- Make color and contrast meets WCAG 2 AA and above
- Fixes `aria-label` on button "copy link" in posts
d4tnq added a commit to d4tnq/d4tnq.github.io that referenced this issue Aug 3, 2023
perf(ui): improve web accessibility (cotes2020#447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants