Hiding a post results in the incorrect post being hidden

[robgoyal]

Checklist

• I have read the tutorials and know the correct effect of the functional design.
• There are no similar reports on existing issues (including closed ones).
• I found the bug on the latest code of the master branch.

Describe the bug

Note: I read through the tutorials and all of the issues but there's no indication that this is the intended functionality.

By default, Jekyll's pagination filters out any posts that have the hidden:true in the YAML front matter.

However, the logic in _layouts/home.html uses custom sorting to place pinned posts at the top and assign the remaining posts as default. Jekyll's paginate will filter out those posts resulting in an incorrect number of posts that the custom sorting functionality will have to go through. Refer to the screenshots below.

To Reproduce

Steps to reproduce the behavior:

1. Add hidden:true to a post that is NOT at the end.
2. Browse to the home page.
3. You'll notice that the post that was meant to be hidden is not and the LAST post is.

Expected behavior

The post that was assigned with the hidden:true should be hidden.

Screenshots

No Hidden Posts

Hiding One Post

Hiding the "Customize the Favicon" post hides the LAST post which is "Text and Typography".

Software

• Ruby version: 2.7.0p0
• Gem version: 3.1.2
• Bundler version: 2.3.5
• Jekyll version: 4.2.1
• Theme version: 5.0.2

Ruby version: ruby 2.7.0p0
Gem version: 3.1.2
Bundler version: 2.3.5
Jekyll version: 4.2.1
Theme version: 5.0.2

Desktop

Smartphone

Additional context

Unsure if this is just an oversight or intentional, I have not created a PR. To solve this issue, the following line in _layouts/home.html needs to be changed from

{% assign default = site.posts | where_exp: "item", "item.pin != true" %}

to

{% assign default = site.posts | where_exp: "item", "item.pin != true and item.hidden != true" %}

[github-actions]

👋 Hi @robgoyal,

This issue is being automatically closed because it does not follow the issue template. Please DO NOT open another similar issue, try to edit the current issue according to the template, then it will be reopened automatically.

[cotes2020]

Hi @robgoyal,

Until I saw this issue, I didn't know that the pagination plugin had the option hidden. So this bug remains.

Thanks for the bug report, very detailed and specific. If you plan to submit the above changes to a PR, I will merge it without hesitation.