-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Russian locale #1308
Update Russian locale #1308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Periecle, since you are the author of this file, could you please help review this PR?
"Personal style of wording" been before mine corrections I thought about it, but decided to leave it as it was |
@cotes2020 The proposed changes are reasonable, and the translation is much better. Approve from my side. @DmitriyFrogo, good work. |
✅ Fixed Also I have thoughts about "publications" and "posts" What word should we use in the future? |
Seems like I don't have any themes to discuss |
Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
@cotes2020, better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriyFrogo Yeah, looks good to me.
@Periecle this PR will be merged if you approve. Thanks for your time!
@cotes2020 seems great to me. Approved 👍 |
Type of change
Description
Update Russian localization
Additional context
For future improvements to Russian locale, we need third and fourth form in additional to "singular" and "plural"
IDK how to explain it to a person who doesn't know Russian, but I have example :D
post = пост [singular]
posts = посты [plural]
1 post = 1 пост [singular]
2 posts = 2 поста [3rd]
3 posts = 3 поста [3rd]
...
5 posts = 5 постов [4th]
6 posts = 6 постов [4th]
...
100 posts = 100 постов [4th]
101 posts = 101 пост [singular]
102 posts = 102 поста [3rd]