Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Russian locale #1308

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Update Russian locale #1308

merged 5 commits into from
Oct 9, 2023

Conversation

DmitriyFrogo
Copy link
Contributor

@DmitriyFrogo DmitriyFrogo commented Oct 8, 2023

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (refactoring and improving code)

Description

Update Russian localization

Additional context

For future improvements to Russian locale, we need third and fourth form in additional to "singular" and "plural"
IDK how to explain it to a person who doesn't know Russian, but I have example :D

post = пост [singular]
posts = посты [plural]

1 post = 1 пост [singular]
2 posts = 2 поста [3rd]
3 posts = 3 поста [3rd]
...
5 posts = 5 постов [4th]
6 posts = 6 постов [4th]
...
100 posts = 100 постов [4th]
101 posts = 101 пост [singular]
102 posts = 102 поста [3rd]

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Russian, but I checked the original translation and your changes with Google Translate and the English is the same in both, so maybe your changes are just a difference in personal style of wording?

ru-locale

@cotes2020 cotes2020 self-requested a review October 8, 2023 22:26
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Periecle, since you are the author of this file, could you please help review this PR?

@DmitriyFrogo
Copy link
Contributor Author

I don't speak Russian, but I checked the original translation and your changes with Google Translate and the English is the same in both, so maybe your changes are just a difference in personal style of wording?

In Russia, we can replace Home with Главная (Main), because of "Домашняя страница" is very long and breaks one line button style:
home

Archives - архивы (many)
Archive - архив (one)

IDK, why previous author translate this like this

Also I fixed "next" and "prev", because they misaligned

Also "posts" in Russian in main branch called "publications"

@DmitriyFrogo
Copy link
Contributor Author

"Personal style of wording" been before mine corrections
I can suggest to change "publications" to "posts", like in English locale
Also I can suggest to change "Older" = "Previous publication" / "Newer" = "Next Publication" to "Older" = "Старее" and "Newer" = "Новее", like in English locale

I thought about it, but decided to leave it as it was
It sounds more literary

@Periecle
Copy link
Contributor

Periecle commented Oct 9, 2023

@cotes2020 The proposed changes are reasonable, and the translation is much better. Approve from my side.

@DmitriyFrogo, good work.
Except change from "Aрхив" to "Архивы". The English word "Archives" in that context means singular "Aрхив," not many archives. I would suggest we leave "Архив" as-is.

@DmitriyFrogo
Copy link
Contributor Author

@DmitriyFrogo, good work. Except change from "Aрхив" to "Архивы". The English word "Archives" in that context means singular "Aрхив," not many archives. I would suggest we leave "Архив" as-is.

✅ Fixed

Also I have thoughts about "publications" and "posts"
Posts - more "digital" word, and when we think about "blogs", we know that we "writing posts", not "publications"
Publications - more old style word, I think, but more literary than "posts"

What word should we use in the future?

_data/locales/ru-RU.yml Outdated Show resolved Hide resolved
@DmitriyFrogo
Copy link
Contributor Author

Seems like I don't have any themes to discuss
@cotes2020, if all right, you can merge new changes

_data/locales/ru-RU.yml Outdated Show resolved Hide resolved
DmitriyFrogo and others added 2 commits October 9, 2023 15:55
Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
@DmitriyFrogo
Copy link
Contributor Author

@cotes2020, better?

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitriyFrogo Yeah, looks good to me.

@Periecle this PR will be merged if you approve. Thanks for your time!

@Periecle
Copy link
Contributor

Periecle commented Oct 9, 2023

@cotes2020 seems great to me. Approved 👍

@cotes2020 cotes2020 merged commit 7b7e69a into cotes2020:master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants