Add Mastodon sharing link #1344
Conversation
There was a problem hiding this comment.
Thanks for submitting this feature, it works fine. But there are still a lot of improvements that can be made, such as the definition of the YAML configuration, code snippets for Liquid/HTML/CSS, etc.
Don't worry, I'll add a new commit later to complete these improvements.
|
I've added a new refactoring commit (1a28db4) for you to review. If you have any ideas for changes, feel free to leave a comment and let me know. Otherwise I'll merge this PR. |
|
@cotes2020 Thank you! 💖 Thanks for 👀 on this, but also for refactoring it. It was not my intention to give you work. While I don't know much front-end things, I would gladly have tried to figure it out given a pointer or two. I only intended to share a neat feature. LGTM, but as mentioned I may not be the best one to say that. And thanks again. ✨ |
|
Okay, I'll merge this PR after I refine some details. |
Adds a "share to Mastodon" button as a link sharing option using @justinribeiro's share-to-mastodon package Discussion of proposed change - #1324 --------- Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com>
Type of change
Description
This PR adds a "share to Mastodon" button as a link sharing option using @justinribeiro's share-to-mastodon package (GitHub and NPM). I made a best guess at the correct CSS color variables to use and it seems to look alright.
_data/share.yml_includes/post-sharing.htmlto only add the button if it was selected as an optionAdditional context
Discussion of proposed change - #1324
Example site w/ change in place - https://some-natalie.dev/