Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use travis for testing linux build on Ubuntu 14.04.5 LTS #594

Merged
merged 1 commit into from
Nov 1, 2018
Merged

use travis for testing linux build on Ubuntu 14.04.5 LTS #594

merged 1 commit into from
Nov 1, 2018

Conversation

Dushistov
Copy link
Contributor

  • fix build_cmake/scripts/build_unix.sh to return not 0 on error

- fix build_cmake/scripts/build_unix.sh to return not 0 on error
@Dushistov
Copy link
Contributor Author

Dushistov commented Oct 29, 2018

After fix of #592 build stills failed, at now because of a36949f :

diff --git a/Replicator/tests/ReplicatorLoopbackTest.cc b/Replicator/tests/ReplicatorLoopbackTest.cc
index 548ef3a6..fa8dfdc2 100644
--- a/Replicator/tests/ReplicatorLoopbackTest.cc
+++ b/Replicator/tests/ReplicatorLoopbackTest.cc
@@ -12,6 +12,7 @@
 #include "Database.hh"
 #include "PrebuiltCopier.hh"
 #include <chrono>
+#include "betterassert.hh"
 
 using namespace litecore::actor;
 
@@ -778,7 +779,8 @@ TEST_CASE_METHOD(ReplicatorLoopbackTest, "Push Validation Failure", "[Push]") {
     auto pullOptions = Replicator::Options::passive();
     atomic<int> validationCount {0};
     pullOptions.callbackContext = &validationCount;
-    pullOptions.pullValidator = [](FLString docID, FLDict body, void *context)->bool {
+    pullOptions.pullValidator = [](FLString docID, C4RevisionFlags flags, FLDict body, void *context)->bool {
+        assert_always(flags == 0);      // can't use CHECK on a bg thread
         ++(*(atomic<int>*)context);
         return (Dict(body)["birthday"].asstring() < "1993");
     };

looks like library and test code build with NDEBUG and without NDEBUG correspondingly.

So I suggest use travis CI to check linux build, it is free for public repositories,
but you need to login to https://travis-ci.org with your github account to enable for your repository.
I enabled travis-ci build for my fork of your repo.

In this PR I add build against ubuntu 14 lts, with clang-7.

It is failed because of a36949f,
you can see full log here:

https://api.travis-ci.org/v3/job/448020342/log.txt

@snej
Copy link
Collaborator

snej commented Oct 30, 2018

I fixed the assert_always issue in Fleece commit ef619cff yesterday; sorry about that.

@snej
Copy link
Collaborator

snej commented Oct 30, 2018

FYI, we have our own internal CI using Jenkins, including a build for Android, but no Ubuntu builds. It took us a while to realize the build was broken, because a typo in the Jenkins config was causing the emails to fall on the floor.

Having Travis too seems like a good idea, esp. since it seems to turn up some build problems that don't happen on Android, even though Android is Linux (right?)

@snej snej requested a review from borrrden October 30, 2018 17:49
@snej
Copy link
Collaborator

snej commented Oct 30, 2018

@borrrden, the changes look good to me, but you're more in tune with Linux and CMake, so could you double-check, and merge if it's ok? Then we can add our own Travis build.

@borrrden borrrden merged commit d5dbd26 into couchbase:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants