Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binaries built from Jenkins have +CHANGES in the user-agent's commit hash #2199

Closed
pasin opened this issue Aug 29, 2018 · 3 comments
Closed

Binaries built from Jenkins have +CHANGES in the user-agent's commit hash #2199

pasin opened this issue Aug 29, 2018 · 3 comments
Assignees
@pasin
Labels
Build P1: high
Milestone
2.5.0

Comments

@pasin
Copy link
Contributor

pasin commented Aug 29, 2018 •
edited
Loading

Currently the binary built from Jenkins has +CHANGES in the user-agent's commit hash. See below for an example:

CouchbaseLite/2.1.0 (Swift; iOS 11.4; iPhone) Build/263 Commit/ea6ccc5d+CHANGES LiteCore/2.1.0 (263)

We need to add LiteCore-EE and some other EE schemes that we copy to couchbase-lite-ios during build to the .gitignore list.
@pasin pasin added the Build label Aug 29, 2018
@pasin pasin added this to the 2.5.0 milestone Aug 29, 2018
@pasin pasin changed the title Binaries built from Jenkins has +CHANGES in the user-agent's commit hash Binaries built from Jenkins have +CHANGES in the user-agent's commit hash Aug 29, 2018
@pasin
Copy link
Contributor Author

pasin commented Sep 12, 2018

Fixed by 01d2a77 and 174bbde.

@pasin pasin closed this as completed Sep 12, 2018
@pasin pasin reopened this Sep 18, 2018
@pasin
Copy link
Contributor Author

pasin commented Sep 18, 2018

Need more fix to eliminate this issue.

@pasin pasin self-assigned this Sep 18, 2018
@djpongh djpongh modified the milestones: 2.5.0, Iridium Sep 19, 2018
@pasin
Copy link
Contributor Author

pasin commented Oct 22, 2018

Closed as fixed.

@pasin pasin closed this as completed Oct 22, 2018
@pasin pasin removed the ready label Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasin pasin

Labels
Build P1: high
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@pasin @djpongh