Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBL-1910: maxAttempts, maxAttemptWaitTime, heartBeat #2840

Merged
merged 12 commits into from
May 26, 2021
Merged

CBL-1910: maxAttempts, maxAttemptWaitTime, heartBeat #2840

merged 12 commits into from
May 26, 2021

Commits on May 20, 2021

  1. CBL-1910: update to maxAttempts

    @jayahariv
    jayahariv committed May 20, 2021
    Configuration menu
    Copy the full SHA
    d4f6497 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. update the swift unit test for maxAttempt

    @jayahariv
    jayahariv committed May 21, 2021
    Configuration menu
    Copy the full SHA
    3211513 View commit details
    Browse the repository at this point in the history

  2. update maxAttemptWaitTime and heartbeat props as well

    @jayahariv
    jayahariv committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f4b9fec View commit details
    Browse the repository at this point in the history

  3. fix: unit test to skip zero incase of invalid test

    @jayahariv
    jayahariv committed May 21, 2021
    Configuration menu
    Copy the full SHA
    53e8de3 View commit details
    Browse the repository at this point in the history

  4. remove the default values from platform side, since it will be handle… 

    …d in lite core
    @jayahariv
    jayahariv committed May 21, 2021
    Configuration menu
    Copy the full SHA
    6065a78 View commit details
    Browse the repository at this point in the history

  5. make maxAttempts unsigned

    @jayahariv
    jayahariv committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f135fa2 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. keep the exception back, since the objc allows to assign -1 to NSUInt… 

    …eger, which is the overflow number. to avoid setting that, we are checking for negatve number
    @jayahariv
    jayahariv committed May 22, 2021
    Configuration menu
    Copy the full SHA
    a4b9b83 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. review changes

    @jayahariv
    jayahariv committed May 25, 2021
    Configuration menu
    Copy the full SHA
    65a668c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into cbl-1910

    @jayahariv
    jayahariv committed May 25, 2021
    Configuration menu
    Copy the full SHA
    cf07320 View commit details
    Browse the repository at this point in the history

  3. skip the check for negative and remove test for negative

    @jayahariv
    jayahariv committed May 25, 2021
    Configuration menu
    Copy the full SHA
    255b83d View commit details
    Browse the repository at this point in the history

  4. avoid refering to the variable than function

    @jayahariv
    jayahariv committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f2687be View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. review comments

    @jayahariv
    jayahariv committed May 26, 2021
    Configuration menu
    Copy the full SHA
    ddbecd8 View commit details
    Browse the repository at this point in the history