Skip to content

Commit

Permalink
MB-21303 Handle ack from dcp producer for control_request correctly
Browse files Browse the repository at this point in the history
control_request for flow control buffer size is added into the
pending request dictionary with nil as SendTo parameter as
gen_server need not reply when it gets response from producer.
This was not handled correctly when stream_response is handled
in the client which is fixed in this patch.

Change-Id: I7afb11adbde79fe2ee0895feac8fec91d563a062
Reviewed-on: http://review.couchbase.org/68525
Reviewed-by: Dave Rigby <daver@couchbase.com>
Reviewed-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: Abhishek Singh <abhishek@couchbase.com>
Tested-by: buildbot <build@couchbase.com>
  • Loading branch information
hsharsha committed Oct 17, 2016
1 parent ed40de6 commit 7a92605
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/couch_dcp/src/couch_dcp_client.erl
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,6 @@ handle_info({get_all_seqs, From}, State) ->
% Reply back to waiting callers
handle_info({stream_response, RequestId, Msg}, State) ->
State3 = case find_pending_request(State, RequestId) of
{_, nil} ->
State;
{ReqInfo, SendTo} ->
State2 = case ReqInfo of
{add_stream, PartId} ->
Expand Down

0 comments on commit 7a92605

Please sign in to comment.