MB-45967 : Retry on DML Failures

It has been seen that a failure on DML N1QL query (such as TMPFAIL,
ENOMEM, NMVB, Connection error, SOCKET_SHUTDOWN etc) are encapsulated as
DML_FAILURE by lcb which is not a retriable / transient error. This can
then result in document mismatch for N1QL handlers. Hence, we need to
retry on DML_FAILUREs too.

Change-Id: I3aef901f4cf283c759394ea8b1b35fe6708f7aa2
Reviewed-on: http://review.couchbase.org/c/eventing/+/152666
Tested-by: <abhishek.jindal@couchbase.com>
Reviewed-by: <ankit.prabhu@couchbase.com>
Reviewed-by: CI Bot

features/query/src/manager.cc

@@ -130,7 +130,7 @@ void QueryFunction(const v8::FunctionCallbackInfo<v8::Value> &args) {
       }
     }
 
-    auto retriable = IsRetriable(first_row.err_code);
+    auto retriable = (first_row.err_code == LCB_ERR_DML_FAILURE) || IsRetriable(first_row.err_code);
     if (!conn_refreshed && (first_row.is_client_auth_error ||
                             first_row.err_code == LCB_ERR_HTTP || retriable)) {
       query_mgr->RefreshTopConnection();