Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for "You must encode binary in a byte array or interfa… #29

Closed
wants to merge 1 commit into from

Conversation

tleyden
Copy link
Contributor

@tleyden tleyden commented Mar 17, 2017

@cb-sdk-robot
Copy link

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: tra***den@gmacom

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

@tleyden
Copy link
Contributor Author

tleyden commented Mar 17, 2017

@brett19 did this create an actual gerrit review?

I only see the new-agreement link, and when I follow it I get:

screen shot 2017-03-17 at 11 40 47 am

and can't get past it

@brett19
Copy link
Member

brett19 commented Mar 17, 2017

Hey @tleyden ,
This is probably because you are already logged into Gerrit, so clicking the link shows your already-signed agreement. You need to add the email that is referenced in the message above to your Gerrit account.
Cheers, Brett

@tleyden
Copy link
Contributor Author

tleyden commented Mar 17, 2017

Cheers @brett19 -- I tried adding the email account that the cb-sdk-bot mentioned in gerrit, but it's not working.

Going to catch up w/ @adamcfraser if this looks like a gocb issue or whether we're calling it incorrectly. Will re-open via gerrit directly if so.

@tleyden tleyden closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants