Skip to content

Commit

Permalink
GOCBC-220: Fixed tests sporadically (racy) failing.
Browse files Browse the repository at this point in the history
Changes
-------
The Stats test was not initiating a signaller wait, this meant
that the callback for the stats would block waiting for someone
to receive the completion event on the channel.  This would block
the callback loop for the last responding server for the Stats
operation.  Any subsequent operations to this server would never
receive results, as the servers loop would be blocked.

Change-Id: I26772ab757f14153ed208d11f2f2ef16e530d1d7
Reviewed-on: http://review.couchbase.org/80756
Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: Brett Lawson <brett19@gmail.com>
  • Loading branch information
brett19 committed Jul 17, 2017
1 parent 71a8d4d commit 55c36af
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,7 @@ func TestStats(t *testing.T) {
}
})
})
s.Wait(0)
}

func TestGetHttpEps(t *testing.T) {
Expand Down

0 comments on commit 55c36af

Please sign in to comment.