Skip to content

Commit

Permalink
MB-46360: Fix hang in ManifestTest/badNames under AArch64
Browse files Browse the repository at this point in the history
The for loop in this test never exits when compiled under
AArch64. Strictly speaking this is correct behaviour; given 'char' is
actually unsigned by default on AArch64. Fix by using explicitly
signed char type.

Change-Id: I146ab760cfde25ab33a79c653af8cb9502ddc47c
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/153827
Tested-by: Build Bot <build@couchbase.com>
Reviewed-by: Trond Norbye <trond.norbye@couchbase.com>
  • Loading branch information
daverigby authored and trondn committed Jul 6, 2021
1 parent fd262fe commit 71912ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion engines/ep/tests/module_tests/collections/manifest_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ TEST(ManifestTest, toJson) {
#endif // !defined(__clang_major__) || __clang_major__ > 7

TEST(ManifestTest, badNames) {
for (char c = 127; c >= 0; c--) {
for (int8_t c = 127; c >= 0; c--) {
std::string name(1, c);
CollectionsManifest cm({name, 8});

Expand Down

0 comments on commit 71912ed

Please sign in to comment.