Skip to content

Commit

Permalink
Drop support for logging macro
Browse files Browse the repository at this point in the history
The way its implemented isn't supported in C89

Change-Id: I224a59c0e9ad6508fd5cb85389ce14f3c3037738
Reviewed-on: http://review.couchbase.org/26923
Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Tested-by: Trond Norbye <trond.norbye@gmail.com>
  • Loading branch information
trondn committed Jun 13, 2013
1 parent a18d993 commit 5786223
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 17 deletions.
13 changes: 7 additions & 6 deletions adhoc_commands.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include "conflate.h"
#include "conflate_internal.h"
#include "conflate_convenience.h"

bool commands_initialized = false;

Expand All @@ -28,19 +27,21 @@ static enum conflate_mgmt_cb_result process_serverlist(void *opaque,
handle->conf->save_path);

if (priv && strcmp(priv, "yes") == 0) {
CONFLATE_LOG(handle, LOG_LVL_INFO,
"Currently using a private config, ignoring update.");
handle->conf->log(handle->conf->userdata, LOG_LVL_INFO,
"Currently using a private config, ignoring update.");
return RV_OK;
}
free(priv);
}

CONFLATE_LOG(handle, LOG_LVL_INFO, "Processing a serverlist");
handle->conf->log(handle->conf->userdata, LOG_LVL_INFO,
"Processing a serverlist");

/* Persist the config lists */
if (!save_kvpairs(handle, conf, handle->conf->save_path)) {
CONFLATE_LOG(handle, LOG_LVL_ERROR, "Can not save config to %s",
handle->conf->save_path);
handle->conf->log(handle->conf->userdata, LOG_LVL_ERROR,
"Can not save config to %s",
handle->conf->save_path);
}

/* Send the config to the callback */
Expand Down
8 changes: 0 additions & 8 deletions conflate_convenience.h

This file was deleted.

1 change: 0 additions & 1 deletion logging.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "conflate.h"
#include "conflate_internal.h"
#include "conflate_convenience.h"

static char* lvl_name(enum conflate_log_level lvl)
{
Expand Down
1 change: 0 additions & 1 deletion persist.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#include "conflate.h"
#include "conflate_internal.h"
#include "conflate_convenience.h"

kvpair_t* load_kvpairs(conflate_handle_t *handle, const char *filename)
{
Expand Down
1 change: 0 additions & 1 deletion xmpp.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include "conflate.h"
#include "conflate_internal.h"
#include "conflate_convenience.h"

/** \private */
struct command_def {
Expand Down

0 comments on commit 5786223

Please sign in to comment.