Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active changes feeds not notified when deferred sequences get cached #2626

Closed
adamcfraser opened this issue Jun 8, 2017 · 1 comment
Closed

Active changes feeds not notified when deferred sequences get cached #2626

adamcfraser opened this issue Jun 8, 2017 · 1 comment
Assignees
@tleyden
Labels
bug ffc P1: high
Milestone
1.5.0

Comments

@adamcfraser
Copy link
Collaborator

There are several places in change_cache.go where we call processEntry for non-document updates (skipped sequence handling, unused sequence handling, recent sequence handling), and we're not doing listener notification based on the results of that call. The non-document update doesn't require notification, but it's possible that the processEntry call unblocked some pending sequences that DO require notification.

Need to ensure notification happens when a non-empty list of channels is returned from processEntry, in all situations.
@tleyden
Copy link
Contributor

tleyden commented Jun 8, 2017

Possibly related to #2358

@sethrosetter sethrosetter mentioned this issue Jun 8, 2017
Closed
@djpongh djpongh added this to the 1.5.0 milestone Jun 9, 2017
@djpongh djpongh added the backlog label Jun 9, 2017
@tleyden tleyden self-assigned this Jun 9, 2017
@tleyden tleyden mentioned this issue Jun 9, 2017
Closed
@djpongh djpongh added ready and removed backlog labels Jun 9, 2017
tleyden pushed a commit that referenced this issue Jun 9, 2017
Fixes #2626 processEntry calls can skip notification when it unblocks…
284f79e 
… pending sequences
@tleyden tleyden mentioned this issue Jun 10, 2017
Merged
tleyden pushed a commit that referenced this issue Jun 12, 2017
Fixes #2626 processEntry calls can skip notification when it unblocks…
2f6f378 
… pending sequences
adamcfraser pushed a commit that referenced this issue Jun 12, 2017
@tleyden @adamcfraser
Feature/issue 2626 processentry notification (#2635)
c60cd4d 
* Notes from call w/ Adam

* Notes on container/heap usage

* Fixes #2626 processEntry calls can skip notification when it unblocks pending sequences
@tleyden tleyden mentioned this issue Jun 12, 2017
Closed
@jamesnocentini jamesnocentini changed the title processEntry calls can skip notification when it unblocks pending sequences Possibility of notifications being skipped which can result in sequence numbers to be wrongly allocated Jun 15, 2017
@adamcfraser adamcfraser changed the title Possibility of notifications being skipped which can result in sequence numbers to be wrongly allocated Active changes feeds not notified when deferred sequences are cached Jun 15, 2017
@adamcfraser adamcfraser changed the title Active changes feeds not notified when deferred sequences are cached Active changes feeds not notified when deferred sequences get cached Jun 15, 2017
tleyden added a commit that referenced this issue Jul 28, 2017
@tleyden
Feature/issue 2626 processentry notification (#2635)
03448a6 
* Notes from call w/ Adam

* Notes on container/heap usage

* Fixes #2626 processEntry calls can skip notification when it unblocks pending sequences

# Conflicts:
#	db/change_cache.go
@tleyden tleyden mentioned this issue Jul 28, 2017
Merged
adamcfraser pushed a commit that referenced this issue Jul 28, 2017
@tleyden @adamcfraser
Feature/issue 2626 processentry notification (#2635) (#2751)
e4fd91a 
* Notes from call w/ Adam

* Notes on container/heap usage

* Fixes #2626 processEntry calls can skip notification when it unblocks pending sequences

# Conflicts:
#	db/change_cache.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tleyden tleyden

Labels
bug ffc P1: high
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@tleyden @jamesnocentini @adamcfraser @djpongh