Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure to support redacted logging #3295

Closed
3 tasks
adamcfraser opened this issue Feb 12, 2018 · 1 comment
Closed
3 tasks

Infrastructure to support redacted logging #3295

adamcfraser opened this issue Feb 12, 2018 · 1 comment
Assignees
@bbrks
Milestone
2.1.0

Comments

@adamcfraser
Copy link
Collaborator

  • Add logging w/ redaction API to logging.go
  • Define redacted types
  • Unit testing
@adamcfraser
Copy link
Collaborator Author

Open questions:

  • Is redaction tagging enabled by default in SG?
  • Is there a way to disable redaction tagging via config?

@bbrks bbrks mentioned this issue Feb 12, 2018
Closed
@adamcfraser adamcfraser added this to the 2.1.0 milestone Feb 12, 2018
@bbrks bbrks mentioned this issue Feb 15, 2018
Merged
4 tasks
@bbrks bbrks added review and removed ready labels Feb 15, 2018
This was referenced Feb 15, 2018
Closed
Closed
Closed
Closed
Closed
@djpongh djpongh added ready and removed review labels Feb 26, 2018
@bbrks bbrks added review and removed ready labels Feb 26, 2018
adamcfraser pushed a commit that referenced this issue Feb 28, 2018
@bbrks @adamcfraser
#3295 - Add log redaction infrastructure (#3308)
870efec 
* Add Redactor interface, UserData type, and redacted log functions

* Add global toggle for RedactUserData

* Improve benchmark for UserData Enabled/Disabled

* Remove incorrect key param in redacted log funcs

* Remove unnecessary bench ResetTimer

* Add ToUD helper method

* Use log redaction in auth package

* Expand redacted args slice

* Add unit test for redacted log function outputs

* Reassign global logger back to original

* Disable RedactUserData by default

* Add redaction to missed warn

* Move log redaction into log package

* revert auth

* Move log redaction back into base

* Moved RedactionLevel into redactor file, made Redact function private again, added test for RedactionLevel
@bbrks bbrks closed this as completed Mar 1, 2018
@bbrks bbrks removed the review label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@bbrks @adamcfraser @djpongh