Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-187: Add option to enable periodic compact #3928

Merged
merged 11 commits into from May 2, 2019
Merged

CBG-187: Add option to enable periodic compact #3928

merged 11 commits into from May 2, 2019

Conversation

JFlath
Copy link
Contributor

@JFlath JFlath commented Jan 18, 2019 •
edited

No description provided.

JFlath
JFlath commented Jan 18, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
JFlath
JFlath commented Jan 18, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
@bbrks
Copy link
Member

bbrks commented Jan 18, 2019

We'll need to think about how to handle this across multiple SG nodes, as described in CBG-187

@coveralls
Copy link

coveralls commented Jan 18, 2019 •
edited

Coverage Status

Coverage decreased (-0.02%) to 60.76% when pulling 4010a0e on feature/CBG-187 into 9e9cf3f on master.

@JFlath
Copy link
Contributor Author

JFlath commented Jan 18, 2019

... I totally remembered that. Honest.

I did say MVP - can I get away with that? :P

JFlath
JFlath commented Jan 18, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser requested changes Jan 20, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
@JFlath JFlath force-pushed the feature/CBG-187 branch 5 times, most recently from 59f9def to e180319 Compare January 21, 2019 13:22
JFlath
JFlath commented Jan 21, 2019
View reviewed changes
rest/server_context.go Outdated Show resolved Hide resolved
JFlath
JFlath commented Jan 21, 2019
View reviewed changes
rest/config.go Outdated Show resolved Hide resolved
JFlath
JFlath commented Jan 21, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
@adamcfraser adamcfraser added this to the Cobalt milestone Jan 28, 2019
@JRascagneres JRascagneres changed the title Add option to enable periodic Compact() (CBG-187) CBG-187: Add option to enable periodic compact Apr 29, 2019
bbrks
bbrks reviewed Apr 29, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
bbrks
bbrks reviewed Apr 29, 2019
View reviewed changes
db/database.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser requested changes Apr 29, 2019
View reviewed changes
base/expvar.go Outdated Show resolved Hide resolved
db/database.go Show resolved Hide resolved
rest/config.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
bbrks
bbrks requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback ahead of our call

db/database.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
rest/server_context.go Outdated Show resolved Hide resolved
base/expvar.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser requested changes Apr 30, 2019
View reviewed changes
db/utils.go Outdated Show resolved Hide resolved
db/utils.go Outdated Show resolved Hide resolved
db/utils.go Show resolved Hide resolved
db/change_cache.go Show resolved Hide resolved
bbrks
bbrks requested changes May 1, 2019
View reviewed changes
rest/server_context.go Outdated Show resolved Hide resolved
db/database.go Outdated Show resolved Hide resolved
db/utils.go Outdated Show resolved Hide resolved
db/utils.go Outdated Show resolved Hide resolved
db/utils.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser requested changes May 1, 2019
View reviewed changes
rest/server_context.go Show resolved Hide resolved
@adamcfraser adamcfraser merged commit 1a7fced into master May 2, 2019
@adamcfraser adamcfraser deleted the feature/CBG-187 branch May 2, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks requested changes

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cobalt
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JFlath @bbrks @coveralls @adamcfraser @pasin @JRascagneres