Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-812 - Fixes infinite loop caused by stale view query when running compact #4544

Merged
merged 3 commits into from Apr 1, 2020
Merged

CBG-812 - Fixes infinite loop caused by stale view query when running compact #4544

merged 3 commits into from Apr 1, 2020

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Apr 1, 2020

No description provided.

@bbrks bbrks requested a review from adamcfraser April 1, 2020 16:27
bbrks
bbrks commented Apr 1, 2020
View reviewed changes
db/query.go Outdated Show resolved Hide resolved
@adamcfraser adamcfraser changed the title CBG-812 - Fixes infinte loop caused by stale view query when running compact CBG-812 - Fixes infinite loop caused by stale view query when running compact Apr 1, 2020
@coveralls
Copy link

coveralls commented Apr 1, 2020 •
edited

Coverage Status

Coverage increased (+0.05%) to 61.802% when pulling 3569df2 on CBG-812-compact-view-query-stale-fix into 8084478 on master.

adamcfraser
adamcfraser requested changes Apr 1, 2020
View reviewed changes
db/query.go Outdated Show resolved Hide resolved
adamcfraser
adamcfraser approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamcfraser adamcfraser merged commit 759cf17 into master Apr 1, 2020
@adamcfraser adamcfraser deleted the CBG-812-compact-view-query-stale-fix branch April 1, 2020 17:32
bbrks added a commit that referenced this pull request Sep 22, 2020
@bbrks
Backport CBG-812 to 2.7.4 - Fixes infinite loop caused by stale view …
2fc4049 
…query when running compact (#4544)

* CBG-812 - Fixes infinte loop caused by stale view query when running compact

* Use consistency param

* Remove stale parameter and hardcode
@bbrks bbrks mentioned this pull request Sep 22, 2020
Merged
adamcfraser pushed a commit that referenced this pull request Sep 22, 2020
@bbrks
Backport CBG-812 to 2.7.4 - Fixes infinite loop caused by stale view …
4f44206 
…query when running compact (#4544) (#4796)

* CBG-812 - Fixes infinte loop caused by stale view query when running compact

* Use consistency param

* Remove stale parameter and hardcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbrks @coveralls @adamcfraser