CBG-771 Refactor CfgSG for reuse by sg-replicate #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move CfgSG to database context to support use by both import and sg-replicate2. Use distinct logging contexts for cbgt and cfgSG. Switch CfgSG to use Bucket (instead of gocbBucket) for testing flexibility. Make CouchbaseBucketGoCB.Spec public to avoid nested StartShardedDCPFeed calls.
bbrks
requested changes
May 1, 2020
Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
bbrks
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite to CBG-771 work.
Move CfgSG to database context to support use by both import and sg-replicate2.
Use distinct logging contexts for cbgt and cfgSG.
Switch CfgSG to use Bucket (instead of gocbBucket) for testing flexibility.
Make CouchbaseBucketGoCB.Spec public to avoid nested StartShardedDCPFeed calls.