Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GetTestKeyNamespace with t.Name #4572

Merged
merged 2 commits into from May 13, 2020
Merged

Replace GetTestKeyNamespace with t.Name #4572

merged 2 commits into from May 13, 2020

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented May 7, 2020

I want to use GetTestKeyNamespace() from the db package, so opening standalone PR for this.

@bbrks bbrks requested a review from adamcfraser May 7, 2020 18:22
@coveralls
Copy link

coveralls commented May 7, 2020 •
edited

Coverage Status

Coverage decreased (-0.01%) to 61.715% when pulling 814fa6e on make_GetTestKeyNamespace_public into 4fa7d54 on master.

adamcfraser
adamcfraser previously approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but as discussed you could review whether getTestKeyNamespace is still needed now that it's just returning t.Name().

@bbrks bbrks changed the title Make GetTestKeyNamespace public Replace GetTestKeyNamespace with t.Name May 13, 2020
@bbrks bbrks requested a review from adamcfraser May 13, 2020 15:30
@adamcfraser adamcfraser merged commit 8c57c2b into master May 13, 2020
@adamcfraser adamcfraser deleted the make_GetTestKeyNamespace_public branch May 13, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbrks @coveralls @adamcfraser