Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-769 Replication rebalance #4573

Merged
merged 3 commits into from May 11, 2020
Merged

CBG-769 Replication rebalance #4573

merged 3 commits into from May 11, 2020

Conversation

adamcfraser
Copy link
Collaborator

Implementation of RebalanceReplications() to evenly distribute replications across participating nodes in replication config.

@adamcfraser
CBG-769 Replication rebalance
f2be988 
Implementation of RebalanceReplications() to evenly distribute replications across participating nodes in replication config.
@coveralls
Copy link

coveralls commented May 7, 2020 •
edited

Coverage Status

Coverage increased (+0.06%) to 61.789% when pulling 10e9508 on CBG-769 into 4fa7d54 on master.

bbrks
bbrks previously approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Just suggested an extra test case for coverage of a single-node early-return.

db/sg_replicate_cfg_test.go Show resolved Hide resolved
@adamcfraser @bbrks
Update db/sg_replicate_cfg_test.go
2127849 
Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
@bbrks bbrks merged commit 82489a3 into master May 11, 2020
@bbrks bbrks deleted the CBG-769 branch May 11, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamcfraser @coveralls @bbrks