CBG-1076: Ensure pruning of tombstoned branches #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
requested changes
Sep 28, 2020
bbrks
approved these changes
Sep 28, 2020
JRascagneres
added a commit
that referenced
this pull request
Jan 15, 2021
bbrks
pushed a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously behaviour was to exit out if the maximum depth (as calculated in
computeDepthsAndFindLeaves) was less than the allowed maximum depth as set through revs_limit. However, this would mean that no processing would be done to find tombstoned branches such as disconnected ones referenced in this ticket.Altered this to ensure this always runs and have added a test to ensure this is the case.
For reference:
Revtree (prior to fix prune wouldn't alter this):
Revtree after prune: