[2.8.1 Backport] CBG-1235 - Add option to hide product version info from non-admin requests #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om non-admin requests (#4928) * CBG-759 - Add option to hide product info from non-admin requests * Scope placeholders in version.go to prevent accidental usage * Have default ProductName const (for use in testing) * Omit product name from Basic auth realm when hide_product_info=true * Hide product version only * Fix test assertions for last change * Address PR comments (add rootResponse struct and build wwwAuthenticateHeader ahead of time)
adamcfraser
previously approved these changes
Jan 19, 2021
adamcfraser
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4928 to 2.8.1
base/version.gochanges