Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8.1] CBG-1276 - Allow network= connstr override for cbdatasource DCP feeds #4946

Merged
merged 1 commit into from Jan 25, 2021

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Jan 22, 2021

Opened as a draft for early feedback prior to more thorough testing.

  • Allows users to specify a network=... option in the connstr.
    • Default is "auto" - which uses the heuristic to pick between "default" or "external"
    • Can be set to "default" to force internal networking (no alternate address heuristic)
    • Can be set to an arbitrary network name to force alternate address for that network name (e.g. "external", or "foo")
  • Default behaviour for users not specifying a network connstr option should be unchanged.
  • A bit more logging around the shims.

@coveralls
Copy link

coveralls commented Jan 22, 2021

Coverage Status

Coverage decreased (-0.04%) to 65.079% when pulling d33225c on CBG-1276 into a89e637 on release/2.8.1.

@bbrks bbrks marked this pull request as ready for review January 25, 2021 17:01
@adamcfraser adamcfraser merged commit c508f8b into release/2.8.1 Jan 25, 2021
@adamcfraser adamcfraser deleted the CBG-1276 branch January 25, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants