CBG-2711 add 3 node cluster option to jenkins #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
requested changes
Apr 17, 2023
| ./integration-test/start_server.sh "${COUCHBASE_SERVER_VERSION}" | ||
| else | ||
| ./integration-test/start_server.sh -m "${COUCHBASE_SERVER_VERSION}" | ||
| export SG_TEST_BUCKET_NUM_REPLICAS=1 |
There was a problem hiding this comment.
Num replicas here should be zero, right?
There was a problem hiding this comment.
I think it should be 1 because this is multi-node cluster and we want at least one replica for each bucket?
There was a problem hiding this comment.
My bad - read the if backwards.
Should we specify 2 replicas in that case, if we know there are 3 CB Data nodes?
- pull out the grep change from this PR - parameterize docker-compose (jenkins only) - allow JENKINS_URL to be unset
bbrks
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create ./integration-test/start_server.sh which allows you to start a cluster in a multinode or a single node setup. The intent is that SG developers could use this to set up clusters but I think I need another PR for this to work on OS X.
When creating a 3 node cluster (MULTI_NODE on jenkins), it will create each bucket with 1 replica.
Questions:
JENKINS_URLis set.--volume ${DOCKER_CBS_ROOT_DIR}/cbs:/root --volume ${WORKSPACE_ROOT}:/workspace? It seems like it is easier to use docker volumes and just do adocker exec -t couchbase /opt/couchbase/bin/cbcollect_info /workspace/cbcollect.zip && docker cp couchbase:/workspace/cbcollect.zip cbcollect.zipto get the file. The only reason to mount the disk seems like would be if we pick up partial files from checks. I can't figure out why we bind mount the/rootvolume at all.Ran 6.6.5,7.1.4,7.0.3 with MULTI_NODE on and off for a base DCP test.