Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-2911 allow /db/ if default collection is configured with other named collections #6222

Merged
merged 4 commits into from
May 2, 2023
Merged

CBG-2911 allow /db/ if default collection is configured with other named collections #6222

merged 4 commits into from
May 2, 2023

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented May 1, 2023 •
edited

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@adamcfraser adamcfraser assigned torcolvin and unassigned adamcfraser May 2, 2023
@torcolvin torcolvin assigned adamcfraser and unassigned torcolvin May 2, 2023
@adamcfraser adamcfraser merged commit 07d12c3 into master May 2, 2023
24 checks passed
@adamcfraser adamcfraser deleted the CBG-2911 branch May 2, 2023 23:03
torcolvin added a commit that referenced this pull request May 9, 2023
@torcolvin @bbrks
CBG-2911 allow /db/ if default collection is configured with other na…
7627d0b 
…med collections (#6222)

* Add skipped test to repro CBG2911

* CBG-2911 allow default collection to map to default collection if exists

* clarify cases on matching keyspace

* Add additional comments

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
torcolvin added a commit that referenced this pull request May 9, 2023
@torcolvin @bbrks
CBG-2911 allow /db/ if default collection is configured with other na…
2f16e50 
…med collections (#6222) (#6230)

* Add skipped test to repro CBG2911

* CBG-2911 allow default collection to map to default collection if exists

* clarify cases on matching keyspace

* Add additional comments

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@torcolvin @adamcfraser @bbrks