CBG-3108 only log relevant SG indexes #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
force-pushed
the
CBG-3108
branch
3 times, most recently
from
03c3799
to
e53e099
Compare
adamcfraser
requested changes
Jun 20, 2023
rest/config.go
Outdated
| @@ -478,6 +478,9 @@ func readFromPath(path string, insecureSkipVerify bool) (rc io.ReadCloser, err e | |||
|
|
|||
| func (dbConfig *DbConfig) AutoImportEnabled() (bool, error) { | |||
| if dbConfig.AutoImport == nil { | |||
| if !dbConfig.UseXattrs() { | |||
There was a problem hiding this comment.
Is this change required for this PR? It seems unrelated.
There was a problem hiding this comment.
This change already exists on master and if I do a git diff origin/master I don't see this change so I don't know what github is doing here.
- add context based logging to include bucket and collection information
adamcfraser
approved these changes
Jun 21, 2023
torcolvin
added a commit
that referenced
this pull request
Jun 30, 2023
- add context based logging to include bucket and collection information
torcolvin
added a commit
that referenced
this pull request
Jun 30, 2023
- add context based logging to include bucket and collection information
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
- add context based logging to include bucket and collection information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit, just log SG only indexes. I also add which indexes aren't ready yet so we know which indexes are slow to create.
I think the second commit is more comprehensive about logging but might be too much for 3.1.1
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/000/