Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1.1 Backport] CBG-3131: Handle ErrImportCancelled case for OnDemandImportForGet (#6325) #6327

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[3.1.1 Backport] CBG-3131: Handle ErrImportCancelled case for OnDemandImportForGet (#6325) #6327

merged 1 commit into from
Jun 30, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Jun 30, 2023 •
edited

CBG-3131

Clean cherry-pick to backport #6325 to 3.1.1

Integration Tests

@bbrks
CBG-3131: CBG-3110: Handle ErrImportCancelled case for OnDemandImport…
2fdcf14 
…ForGet (#6325)

* Add test to hit ErrImportCancelled case for OnDemandImportForGet panic

* Fix panic for OnDemandImportForGet when import is cancelled (due to purged doc)

* comment describing how `doc == nil` can occur
@torcolvin torcolvin merged commit b38c5c8 into release/3.1.1 Jun 30, 2023
24 checks passed
@torcolvin torcolvin deleted the CBG-3131 branch June 30, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbrks @torcolvin