Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3286 Per-db console log settings #6348

Merged
merged 8 commits into from Aug 21, 2023
Merged

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Jul 31, 2023

CBG-0000

Stores a reference to the database log configuration inside the database-scoped log context, so that we're able to look it up when we log to determine whether to emit the console log or not.

This allows databases to define their own console log level and log keys. Neither of the two settings takes precedence. They're additive (either node OR db log level/key are checked when writing a log line, if either match, it will be logged).

Integration Tests

@bbrks bbrks changed the title Initial implementation of per-db console log settings Per-db console log settings Aug 3, 2023
@bbrks bbrks marked this pull request as ready for review August 3, 2023 14:01
@bbrks bbrks force-pushed the per-db-console-log-settings branch from fb23d92 to 85a4f82 Compare August 10, 2023 10:57
JRascagneres
JRascagneres previously approved these changes Aug 10, 2023
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach seems reasonable - added a question about whether background context makes sense in some cases.

base/logger_external.go Outdated Show resolved Hide resolved
Copy link
Member

@IsaacLambat IsaacLambat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rest API documentation needs updating (docs/api/components/schemas.yaml L1129)

@bbrks bbrks requested a review from IsaacLambat August 15, 2023 15:25
@bbrks bbrks merged commit 39f4dad into master Aug 21, 2023
19 checks passed
@bbrks bbrks deleted the per-db-console-log-settings branch August 21, 2023 09:43
@bbrks bbrks changed the title Per-db console log settings CBG-3286 Per-db console log settings Aug 21, 2023
bbrks added a commit that referenced this pull request Sep 7, 2023
bbrks added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants