Implement Couchbase.Extensions.MultiOp #92
Conversation
Motivation ---------- Provide a standardized, yet flexible, approach for running multiple operations in parallel which is simpler and more performant than other options using Tasks. Modifications ------------- Create the Couchbase.Extensions.MultiOp package with a variety of tests.
| /// <remarks> | ||
| /// Operations are not executed until the observable is subscribed. | ||
| /// </remarks> | ||
| public static IObservable<MultiOpResult<IGetResult>> Get(this ICouchbaseCollection collection, |
There was a problem hiding this comment.
Personally, I like the Get without the Async postfix, however, all of the feedback we got when sdk3 was in early pre-release was that people didn't like it.
There was a problem hiding this comment.
Yeah, I was one of the people who insisted on Async because it gives a clear indication of the method's design. However, I think in this case it actually causes more confusion. It gives the impression that this method returns Task<T>, which it doesn't. Worse, it will encourage users to await the return value. If the IObservable is awaited, then it will wait for all operations to complete but then only return the value of the last operation, dropping all others. I can see this being very confusing.
Perhaps we should consider other method names instead? Like MultiGet instead of Get? Do you have any other ideas?
There was a problem hiding this comment.
Gotcha, I recall we discussed this before (were not awaiting a Task, its an observable). Yeah, I think MultiGet over Get is better, we handle the "Async" potential confusion in docs.
Motivation
Provide a standardized, yet flexible, approach for running multiple
operations in parallel which is simpler and more performant than other
options using Tasks.
Modifications
Create the Couchbase.Extensions.MultiOp package with a variety of tests.