Insert 1bp #13
Open
Insert 1bp #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrasmus
pushed a commit
that referenced
this pull request
Dec 12, 2014
Fix left edge of chromosome bug
pkaleta
reviewed
Mar 20, 2020
| The library does assume that genome sequence is available through a `pygr` | ||
| compatible `SequenceFileDB` object. For an example of writing a wrapper for | ||
| a different genome sequence back-end, see | ||
| [hgvs.tests.genome.MockGenome](hgvs/tests/genome.py). | ||
|
|
||
| ## Flask Web Service |
There was a problem hiding this comment.
Thanks for this contribution!
Do you think this could be done as a separate package that imports the hgvs library? Majority of use cases will require just the library, not the HTTP API.
There was a problem hiding this comment.
Ho @pkaleta totally agree, I can put this as a separate one. When I originally wrote this it was because our pipeline was primarily java and wanted a way to interact with this. Alternatively this can be a multi-package project. Up to you.
Let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flask web service (vcf to cdna and back)
Also changed readme file