Skip to content

Commit

Permalink
Merge pull request #180 from coursera/cliu_allow_double_precision_col…
Browse files Browse the repository at this point in the history
…umns

allow double precision columns
  • Loading branch information
cliu587 committed Nov 18, 2015
2 parents 74f51ed + 7947e97 commit f5a2e41
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions dataduct/database/parsers/tests/test_get_column_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def test_double():
result = get_column_parser().parseString("test_column DOUBLE")
eq_(result['column_type'], 'DOUBLE')

result = get_column_parser().parseString("test_column DOUBLE PRECISION")
eq_(result['column_type'], 'DOUBLE PRECISION')

result = get_column_parser().parseString("test_column FLOAT8")
eq_(result['column_type'], 'FLOAT8')

Expand Down
2 changes: 1 addition & 1 deletion dataduct/database/parsers/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
_bigint = (CaselessKeyword('BIGINT') | CaselessKeyword('INT8'))
_decimal = Combine((CaselessKeyword('DECIMAL') | CaselessKeyword('NUMERIC')) + '(' + Word(nums + ' ,') + ')') # noqa
_real = (CaselessKeyword('REAL') | CaselessKeyword('FLOAT4'))
_double = (CaselessKeyword('DOUBLE') | CaselessKeyword('FLOAT') | CaselessKeyword('FLOAT8')) # noqa
_double = (CaselessKeyword('DOUBLE PRECISION') | CaselessKeyword('FLOAT') | CaselessKeyword('FLOAT8') | CaselessKeyword('DOUBLE')) # noqa
_boolean = CaselessKeyword('BOOLEAN')
_char = (CaselessKeyword('CHAR') | CaselessKeyword('CHARACTER'))
_char |= (CaselessKeyword('NCHAR') | CaselessKeyword('BPCHAR'))
Expand Down

0 comments on commit f5a2e41

Please sign in to comment.